[coreboot-gerrit] Change in coreboot[master]: mb/*/*: Drop VGA_BIOS_FILE and VGA_BIOS_ID on some cases

Nico Huber (Code Review) gerrit at coreboot.org
Sat Jun 23 20:16:45 CEST 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/27212 )

Change subject: mb/*/*: Drop VGA_BIOS_FILE and VGA_BIOS_ID on some cases
......................................................................


Patch Set 1:

I inspired this work because of a simple calculation: If you override
the default per mainboard you might fix loading the OPROM in SeaBIOS
in 1 out of 6 cases, but break it for coreboot in 5 out of 6 (the
chipset default always works in coreboot because it has a compati-
bility list).

What do you think, folks?


-- 
To view, visit https://review.coreboot.org/27212
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b70974b47d04267770c8e91b7663450f0e2dbbb
Gerrit-Change-Number: 27212
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 23 Jun 2018 18:16:45 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180623/f3891aab/attachment.html>


More information about the coreboot-gerrit mailing list