[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945: Fix C1DRBs values when channel B is empty

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27204 )

Change subject: nb/intel/i945: Fix C1DRBs values when channel B is empty
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/27204/5//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27204/5//COMMIT_MSG@9
PS5, Line 9: C1DRBs must be programmed with the same value as C0DRB3
           : when the channel B is empty.
           : If channels are interleaved, C0DRB* is equal to C1DRB*.
The code and the comments suggest this is untrue so what makes you believe it is?



-- 
To view, visit https://review.coreboot.org/27204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26103aac7f920e5696b445e125d33405df4f43b
Gerrit-Change-Number: 27204
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 22 Jun 2018 12:07:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180622/1ac54a8d/attachment.html>