[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable

Caveh Jalali (Code Review) gerrit at coreboot.org
Fri Jun 22 08:14:55 CEST 2018


Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/27185

to review the following change.


Change subject: mb/google/poppy/variants/atlas: add GPIO for bluetooth enable
......................................................................

mb/google/poppy/variants/atlas: add GPIO for bluetooth enable

This configures a GPIO pin for enabling/disabling bluetooth on the
next version of the atlas board.  The default is for bluetooth to be
enabled at this point.

BUG=b:110614620,b:110613353
BRANCH=none
TEST=none

Change-Id: I4ba940e89b1dc03548b7ab44b8f84dc9a3097acb
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/27185/1

diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c
index b374265..d99a0e4 100644
--- a/src/mainboard/google/poppy/variants/atlas/gpio.c
+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c
@@ -213,8 +213,8 @@
 	PAD_CFG_GPI_APIC_INVERT(GPP_E0, NONE, PLTRST),
 	/* E1  : SATAXPCIE1 ==> NC */
 	PAD_CFG_NC(GPP_E1),
-	/* E2  : SATAXPCIE2 ==> NC */
-	PAD_CFG_NC(GPP_E2),
+	/* E2  : SATAXPCIE2 ==> BT_DISABLE_L */
+	PAD_CFG_GPO(GPP_E2, 1, DEEP),
 	/* E3  : CPU_GP0 ==> NC */
 	PAD_CFG_NC(GPP_E3),
 	/* E4  : SATA_DEVSLP0 ==> NC */

-- 
To view, visit https://review.coreboot.org/27185
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ba940e89b1dc03548b7ab44b8f84dc9a3097acb
Gerrit-Change-Number: 27185
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180622/e0013b7a/attachment.html>


More information about the coreboot-gerrit mailing list