[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/atlas: add two new memory options
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Fri Jun 22 07:22:36 CEST 2018
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/27184 )
Change subject: mb/google/poppy/variants/atlas: add two new memory options
......................................................................
Patch Set 1: -Code-Review
(2 comments)
https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants/atlas/Makefile.inc
File src/mainboard/google/poppy/variants/atlas/Makefile.inc:
https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants/atlas/Makefile.inc@12
PS1, Line 12:
One less space to match the formatting on other lines.
https://review.coreboot.org/#/c/27184/1/src/mainboard/google/poppy/variants/atlas/Makefile.inc@12
PS1, Line 12:
other lines don't use a tab here.
--
To view, visit https://review.coreboot.org/27184
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddacdf1e1d0e2bae0c6168c86e54f5f602cd9d19
Gerrit-Change-Number: 27184
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
Gerrit-Comment-Date: Fri, 22 Jun 2018 05:22:36 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180622/43090723/attachment.html>
More information about the coreboot-gerrit
mailing list