[coreboot-gerrit] Change in coreboot[master]: [WIP] mb/google/octopus: Fix unused pins and those with external term...

Fri Jun 22 04:34:55 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27183 )

Change subject: [WIP] mb/google/octopus: Fix unused pins and those with external terminations
......................................................................

Patch Set 1:

(24 comments)

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@96
PS1, Line 96: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@131
PS1, Line 131: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@133
PS1, Line 133: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@134
PS1, Line 134: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@137
PS1, Line 137: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@141
PS1, Line 141: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@166
PS1, Line 166: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@175
PS1, Line 175: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@203
PS1, Line 203: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@226
PS1, Line 226: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@228
PS1, Line 228: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@259
PS1, Line 259: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@94
PS1, Line 94: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@129
PS1, Line 129: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@131
PS1, Line 131: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@132
PS1, Line 132: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@135
PS1, Line 135: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@139
PS1, Line 139: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@164
PS1, Line 164: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@170
PS1, Line 170: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_120, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ0_B -- unused */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@173
PS1, Line 173: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@203
PS1, Line 203: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@227
PS1, Line 227: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/27183/1/src/mainboard/google/octopus/variants/bip/gpio.c@258
PS1, Line 258: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

-- 
To view, visit https://review.coreboot.org/27183
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec62913b0ef47105289838218f5d74c004223c
Gerrit-Change-Number: 27183
Gerrit-PatchSet: 1
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 22 Jun 2018 02:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180622/0b7e2459/attachment.html>