[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Update GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC

Furquan Shaikh (Code Review) gerrit at coreboot.org
Thu Jun 21 17:40:05 CEST 2018


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27179


Change subject: mb/google/octopus: Update GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC
......................................................................

mb/google/octopus: Update GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC

Move GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC under each variant config and
select it for bip and fleex only.

Functional change in this CL is that EC SW sync will be enabled for
phaser.

BUG=b:110523400

Change-Id: If6f37c6b2ee71130b9ed5b10ce92fb23fa1c39fc
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/octopus/Kconfig.name
2 files changed, 9 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/27179/1

diff --git a/src/mainboard/google/octopus/Kconfig b/src/mainboard/google/octopus/Kconfig
index d768604..226e44f 100644
--- a/src/mainboard/google/octopus/Kconfig
+++ b/src/mainboard/google/octopus/Kconfig
@@ -29,7 +29,6 @@
 	bool
 	default y
 	select EC_GOOGLE_CHROMEEC_SWITCHES
-	select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if !BOARD_GOOGLE_YORP
 	select HAS_RECOVERY_MRC_CACHE
 	select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN
 	select VBOOT_LID_SWITCH
diff --git a/src/mainboard/google/octopus/Kconfig.name b/src/mainboard/google/octopus/Kconfig.name
index 182ebe4..f30b46f 100644
--- a/src/mainboard/google/octopus/Kconfig.name
+++ b/src/mainboard/google/octopus/Kconfig.name
@@ -4,23 +4,29 @@
 	bool "->  Octopus"
 	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	select BASEBOARD_OCTOPUS_LAPTOP
+
 config BOARD_GOOGLE_YORP
 	bool "->  Yorp"
 	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	select BASEBOARD_OCTOPUS_LAPTOP
 	select NHLT_DA7219 if INCLUDE_NHLT_BLOBS
+
 config BOARD_GOOGLE_BIP
 	bool "->  Bip"
-	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	select BASEBOARD_OCTOPUS_LAPTOP
+	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
+	select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS
 	select NHLT_RT5682 if INCLUDE_NHLT_BLOBS
+
 config BOARD_GOOGLE_PHASER
 	bool "->  Phaser"
-	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	select BASEBOARD_OCTOPUS_LAPTOP
+	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	select NHLT_DA7219 if INCLUDE_NHLT_BLOBS
+
 config BOARD_GOOGLE_FLEEX
 	bool "->  Fleex"
-	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
 	select BASEBOARD_OCTOPUS_LAPTOP
+	select BOARD_GOOGLE_BASEBOARD_OCTOPUS
+	select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC if CHROMEOS
 	select NHLT_DA7219 if INCLUDE_NHLT_BLOBS

-- 
To view, visit https://review.coreboot.org/27179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If6f37c6b2ee71130b9ed5b10ce92fb23fa1c39fc
Gerrit-Change-Number: 27179
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180621/942d3154/attachment.html>


More information about the coreboot-gerrit mailing list