[coreboot-gerrit] Change in coreboot[master]: sb/intel/common/firmware: Enable me_cleaner for Nehalem

[Nicola Corna (Code Review)]

Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/27178

to look at the new patch set (#2).

Change subject: sb/intel/common/firmware: Enable me_cleaner for Nehalem
......................................................................

sb/intel/common/firmware: Enable me_cleaner for Nehalem

Recent patches in coreboot have fixed the freeze issues related to the
use of me_cleaner on Nehalem.

However, at least on the Lenovo X201, with me_cleaner some PCIe devices
(like the SATA and USB controllers) disappear. In particular, setting
the AltMeDisable bit ("-S" or "-s" flag) makes them disappear
completely, while unsetting it makes them disappear only during cold
boots.

This kind of behaviour was already observed by Youness Alaoui on the
Purism Librem laptops ([1]), and it seems related to some required
board-specific PCIe configuration in the ME's MFS partition.

For this reason, on the Lenovo X201, "-w EFFS" has been added to the
me_cleaner arguments, which whitelists the MFS-equivalent partition for
ME generation 2. This fixes all the issues, and the PCIe devices work as
expected.

[1] https://puri.sm/posts/deep-dive-into-intel-me-disablement/

Change-Id: Ie77a80d2cb4945cf1c984bdb0fb1cc2f18e82ebc
Signed-off-by: Nicola Corna <nicola at corna.info>
---
M src/mainboard/lenovo/x201/Kconfig
M src/southbridge/intel/common/firmware/Kconfig
2 files changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/27178/2
-- 
To view, visit https://review.coreboot.org/27178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie77a80d2cb4945cf1c984bdb0fb1cc2f18e82ebc
Gerrit-Change-Number: 27178
Gerrit-PatchSet: 2
Gerrit-Owner: Nicola Corna <nicola at corna.info>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180621/1ac6f79f/attachment.html>