[coreboot-gerrit] Change in coreboot[master]: inteltool: Add PCI IDs for the C220 PCH series

Patrick Rudolph (Code Review) gerrit at coreboot.org
Wed Jun 20 12:43:21 CEST 2018


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/27168 )

Change subject: inteltool: Add PCI IDs for the C220 PCH series
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:

https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.h@200
PS1, Line 200:  
pelase use two tabs instead of space as seperator


https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.c
File util/inteltool/inteltool.c:

https://review.coreboot.org/#/c/27168/1/util/inteltool/inteltool.c@236
PS1, Line 236: 	 "Intel(R) C8 Mobile"},
The other southbridge names doesn't have an "Intel(R)" prefix, please remove.



-- 
To view, visit https://review.coreboot.org/27168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07a8f2e9cb0ee8677c8fe2c51881147ed81c1a35
Gerrit-Change-Number: 27168
Gerrit-PatchSet: 1
Gerrit-Owner: Quan Tran <qeed.quan at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 20 Jun 2018 10:43:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180620/b2b8d699/attachment.html>


More information about the coreboot-gerrit mailing list