[coreboot-gerrit] Change in coreboot[master]: util/lint/checkpatch_json: Fix checkpatch output keywork match string

Rizwan Qureshi (Code Review) gerrit at coreboot.org
Wed Jun 20 12:37:21 CEST 2018


Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/27170 )

Change subject: util/lint/checkpatch_json: Fix checkpatch output keywork match string
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/27170/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27170/2//COMMIT_MSG@7
PS2, Line 7: keywork
keyword


https://review.coreboot.org/#/c/27170/2//COMMIT_MSG@9
PS2, Line 9: keyword 'ERROR:' , 'WARNING:' & 'FILE:'
so, checkpatch will fail if finds a problem with lines containing "ERROR:" WARNING: FILE:.
These strings are very generic and can be used in source code, can you modify the checkpatch keywords itself.
e.g., CHECKPATCH_ERR, CHECKPATCH_WARN etc.



-- 
To view, visit https://review.coreboot.org/27170
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib690ab34a1ffabc4f83642634fd34beea16a64dc
Gerrit-Change-Number: 27170
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki <naresh.solanki at intel.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 20 Jun 2018 10:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180620/f0aac0f7/attachment.html>


More information about the coreboot-gerrit mailing list