[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373...

Sathyanarayana Nujella (Code Review) gerrit at coreboot.org
Tue Jun 19 21:48:01 CEST 2018


Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/27167


Change subject: mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's
......................................................................

mb/google/poppy/variants/nocturne: Update Slave Addresses of Max98373 Amp's

When played Left Only Audio and Right Only Audio, we observed that Audio
got swapped. Left Data played on Right Speaker and Viceversa.

This patch fixes the above issue.

BUG=b:73635449
TEST=Play Left only & Right only Audio and cross check Audio.

Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/27167/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index f746c08..36dc18e6 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -316,7 +316,7 @@
 				register "uid" = "0"
 				register "desc" = ""RIGHT SPEAKER AMP""
 				register "name" = ""MAXR""
-				device i2c 31 on end
+				device i2c 32 on end
 			end
 			chip drivers/i2c/max98373
 				register "vmon_slot_no" = "6"
@@ -324,7 +324,7 @@
 				register "uid" = "1"
 				register "desc" = ""LEFT SPEAKER AMP""
 				register "name" = ""MAXL""
-				device i2c 32 on end
+				device i2c 31 on end
 			end
 		end # I2C #4 - Audio
 		device pci 1c.0 on

-- 
To view, visit https://review.coreboot.org/27167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie9c417ad0634a76fc8a4126ee75886603f1b3da0
Gerrit-Change-Number: 27167
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180619/8b60f53e/attachment.html>


More information about the coreboot-gerrit mailing list