[coreboot-gerrit] Change in coreboot[master]: lib: Raw import FIT parser

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25739 )

Change subject: lib: Raw import FIT parser
......................................................................


Patch Set 16:

(13 comments)

https://review.coreboot.org/#/c/25739/16/src/include/fit.h
File src/include/fit.h:

https://review.coreboot.org/#/c/25739/16/src/include/fit.h@28
PS16, Line 28: {
open brace '{' following enum go on the same line


https://review.coreboot.org/#/c/25739/16/src/include/fit.h@36
PS16, Line 36: {
open brace '{' following struct go on the same line


https://review.coreboot.org/#/c/25739/16/src/include/fit.h@46
PS16, Line 46: {
open brace '{' following struct go on the same line


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c
File src/lib/fit.c:

https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@194
PS16, Line 194: 	const char *path[] = { "chosen", NULL };
char * array declaration might be better as static const


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@202
PS16, Line 202: 	const char *path[] = { "chosen", NULL };
char * array declaration might be better as static const


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@225
PS16, Line 225: {
open brace '{' following struct go on the same line


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@226
PS16, Line 226: 	unsigned addr_cells;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@227
PS16, Line 227: 	unsigned size_cells;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@231
PS16, Line 231: static uint64_t max_range(unsigned size_cells)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@242
PS16, Line 242: 	unsigned *count = (unsigned *)params->data;
Prefer 'unsigned int *' to bare use of 'unsigned *'


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@242
PS16, Line 242: 	unsigned *count = (unsigned *)params->data;
Prefer 'unsigned int *' to bare use of 'unsigned *'


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@298
PS16, Line 298: 		 * Kernel likes its availabe memory areas at least 1MB
'availabe' may be misspelled - perhaps 'available'?


https://review.coreboot.org/#/c/25739/16/src/lib/fit.c@323
PS16, Line 323: 	unsigned count = 0;
Prefer 'unsigned int' to bare use of 'unsigned'



-- 
To view, visit https://review.coreboot.org/25739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee56db328d7eeffb0eaf829841243b0b9195c199
Gerrit-Change-Number: 25739
Gerrit-PatchSet: 16
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Jun 2018 11:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180619/fd2221c6/attachment.html>