[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Move common uart function to block/uart

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Jun 19 13:08:07 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26164 )

Change subject: soc/intel/common/block: Move common uart function to block/uart
......................................................................


Patch Set 47:

(3 comments)

https://review.coreboot.org/#/c/26164/47/src/soc/intel/apollolake/uart.c
File src/soc/intel/apollolake/uart.c:

https://review.coreboot.org/#/c/26164/47/src/soc/intel/apollolake/uart.c@59
PS47, Line 59: 			                        MAX_GPIO_PAD_PER_UART + index];
code indent should use tabs where possible


https://review.coreboot.org/#/c/26164/47/src/soc/intel/cannonlake/uart.c
File src/soc/intel/cannonlake/uart.c:

https://review.coreboot.org/#/c/26164/47/src/soc/intel/cannonlake/uart.c@52
PS47, Line 52: 			                        MAX_GPIO_PAD_PER_UART + index];
code indent should use tabs where possible


https://review.coreboot.org/#/c/26164/47/src/soc/intel/skylake/uart.c
File src/soc/intel/skylake/uart.c:

https://review.coreboot.org/#/c/26164/47/src/soc/intel/skylake/uart.c@52
PS47, Line 52: 			                        MAX_GPIO_PAD_PER_UART + index];
code indent should use tabs where possible



-- 
To view, visit https://review.coreboot.org/26164
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I109d0e5c942e499cb763bde47cb7d53dfbf5cef6
Gerrit-Change-Number: 26164
Gerrit-PatchSet: 47
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams at intel.com>
Gerrit-Comment-Date: Tue, 19 Jun 2018 11:08:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180619/0cc65b29/attachment.html>


More information about the coreboot-gerrit mailing list