[coreboot-gerrit] Change in coreboot[master]: atlas: support i2c-hid trackpad

[Caveh Jalali (Code Review)]

Hello caveh jalali,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/27126

to review the following change.


Change subject: atlas: support i2c-hid trackpad
......................................................................

atlas: support i2c-hid trackpad

We plan to use i2c-hid compatible trackpads on atlas, so this switches
the trackpad config to i2c-hid.

BUG=b:80662079
BRANCH=none
TEST=used trackpad to verify motion tracking

Change-Id: I2702e61a6aa96250c0c09ea4bd15d0c671eedadc
Signed-off-by: Caveh Jalali <caveh at chromium.org>
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 6 insertions(+), 6 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/27126/1

diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index 7742a83..2789632 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -261,12 +261,12 @@
 		device pci 15.0 on  end # I2C #0 - Touchscreen
 		device pci 15.1 off end # I2C #1
 		device pci 15.2 on
-			chip drivers/i2c/generic
-				register "hid" = ""ELAN0000""
-				register "desc" = ""ELAN Touchpad""
-				register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)"
-				register "wake" = "GPE0_DW0_23" # GPP_A23
-				register "probed" = "1" # may not be present
+			chip drivers/i2c/hid
+				register "generic.hid" = ""ACPI0C50""
+				register "generic.desc" = ""ELAN Touchpad""
+		 		register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A19_IRQ)"
+		 		register "generic.wake" = "GPE0_DW0_23" # GPP_A23
+				register "hid_desc_reg_offset" = "0x01"
 				device i2c 0x15 on end
 			end
 		end # I2C #2 - Trackpad

-- 
To view, visit https://review.coreboot.org/27126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2702e61a6aa96250c0c09ea4bd15d0c671eedadc
Gerrit-Change-Number: 27126
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: caveh jalali <caveh at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180616/cdb5a25a/attachment.html>