[coreboot-gerrit] Change in coreboot[master]: mb/asrock/g41c-gs: Add the revision 1 variant

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21292 )

Change subject: mb/asrock/g41c-gs: Add the revision 1 variant
......................................................................


Patch Set 17:

(16 comments)

https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c
File src/mainboard/asrock/g41c-gs/gpio.c:

https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@73
PS17, Line 73:         .gpio10 = GPIO_LEVEL_LOW,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@73
PS17, Line 73:         .gpio10 = GPIO_LEVEL_LOW,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@74
PS17, Line 74:         .gpio15 = GPIO_LEVEL_LOW,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@74
PS17, Line 74:         .gpio15 = GPIO_LEVEL_LOW,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@75
PS17, Line 75:         .gpio16 = GPIO_LEVEL_HIGH,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@75
PS17, Line 75:         .gpio16 = GPIO_LEVEL_HIGH,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@76
PS17, Line 76:         .gpio18 = GPIO_LEVEL_LOW,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@76
PS17, Line 76:         .gpio18 = GPIO_LEVEL_LOW,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@77
PS17, Line 77:         .gpio20 = GPIO_LEVEL_HIGH,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@77
PS17, Line 77:         .gpio20 = GPIO_LEVEL_HIGH,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@78
PS17, Line 78:         .gpio24 = GPIO_LEVEL_HIGH,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@78
PS17, Line 78:         .gpio24 = GPIO_LEVEL_HIGH,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@79
PS17, Line 79:         .gpio25 = GPIO_LEVEL_LOW,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@79
PS17, Line 79:         .gpio25 = GPIO_LEVEL_LOW,
please, no spaces at the start of a line


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@80
PS17, Line 80:         .gpio27 = GPIO_LEVEL_LOW,
code indent should use tabs where possible


https://review.coreboot.org/#/c/21292/17/src/mainboard/asrock/g41c-gs/gpio.c@80
PS17, Line 80:         .gpio27 = GPIO_LEVEL_LOW,
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/21292
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib69c2ac0a9dc1b5c46220d2d2d5239edc99b0516
Gerrit-Change-Number: 21292
Gerrit-PatchSet: 17
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: AndiR <andir at memeware.net>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Fri, 15 Jun 2018 19:07:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180615/bee2759f/attachment.html>