[coreboot-gerrit] Change in coreboot[master]: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Jun 15 16:42:29 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/27117 )

Change subject: mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS
......................................................................

mainboard/google/Kahlee: All variants identify as Grunt in SMBIOS

All Grunt variants should identify as grunt in SMBIOS so that
they're recognized correctly as a unibuild Grunt variant.

BUG=b:110244268
TEST=Careena identifies as grunt

Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/27117
Reviewed-by: Simon Glass <sjg at chromium.org>
Reviewed-by: Simon Glass <sjg at chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/kahlee/Kconfig
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Simon Glass: Looks good to me, but someone else must approve
  Simon Glass: Looks good to me, approved



diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig
index f5ae3fb..fd43ed6 100644
--- a/src/mainboard/google/kahlee/Kconfig
+++ b/src/mainboard/google/kahlee/Kconfig
@@ -54,8 +54,7 @@
 
 config MAINBOARD_PART_NUMBER
 	string
-	default "Careena" if BOARD_GOOGLE_CAREENA
-	default "Grunt" if BOARD_GOOGLE_GRUNT
+	default "Grunt"
 
 config DEVICETREE
 	string

-- 
To view, visit https://review.coreboot.org/27117
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf254149fbec9551d9220018d6d6a0a1be741538
Gerrit-Change-Number: 27117
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180615/51c435b4/attachment.html>


More information about the coreboot-gerrit mailing list