[coreboot-gerrit] Change in coreboot[master]: cbfstool: Use endian.h and functions from commonlib

Nico Huber (Code Review) gerrit at coreboot.org
Fri Jun 15 14:25:57 CEST 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/27116 )

Change subject: cbfstool: Use endian.h and functions from commonlib
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/27116/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27116/1//COMMIT_MSG@18
PS1, Line 18: We use functions from commonlib/endian.h already in cbfstool.
Superfluous to say, as commonlib was introduced exactly for that.



-- 
To view, visit https://review.coreboot.org/27116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I106274cf9c69e1849f848920d96a61188f895b36
Gerrit-Change-Number: 27116
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 15 Jun 2018 12:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180615/afd85517/attachment.html>


More information about the coreboot-gerrit mailing list