[coreboot-gerrit] Change in coreboot[master]: cbfstool: Use endian.h and functions from commonlib

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/27116


Change subject: cbfstool: Use endian.h and functions from commonlib
......................................................................

cbfstool: Use endian.h and functions from commonlib

The endian conversion function be32toh() is defined in
src/include/endian.h, however this file is not used for cbfstool
compilation. Currently the one provided by the host is used and if the
host does not provide this endian.h file, the build will fail.
However, we do have endian conversion functions in commonlib/endian.h
which is available for cbfstool compilation.

Switch from be32toh() to read_be32() in order to avoid relying on a
host provided include file.
We use functions from commonlib/endian.h already in cbfstool.

Change-Id: I106274cf9c69e1849f848920d96a61188f895b36
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M util/cbfstool/cbfs-mkpayload.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/27116/1

diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c
index 6dc1634..e26c530 100644
--- a/util/cbfstool/cbfs-mkpayload.c
+++ b/util/cbfstool/cbfs-mkpayload.c
@@ -18,6 +18,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <commonlib/endian.h>
 
 #include "elfparsing.h"
 #include "common.h"
@@ -426,7 +427,7 @@
 	DEBUG("start: parse_fit_to_payload\n");
 
 	fdt_h = buffer_get(input);
-	if (be32toh(fdt_h->magic) != FDT_HEADER_MAGIC) {
+	if (read_be32(&fdt_h->magic) != FDT_HEADER_MAGIC) {
 		INFO("Not a FIT payload.\n");
 		return -1;
 	}

-- 
To view, visit https://review.coreboot.org/27116
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I106274cf9c69e1849f848920d96a61188f895b36
Gerrit-Change-Number: 27116
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180615/31b327fa/attachment.html>