[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/intel/cannonlake: Use bootblock common stage

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25811 )

Change subject: [WIP] soc/intel/cannonlake: Use bootblock common stage
......................................................................


Patch Set 7:

(4 comments)

https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/report_platform.c
File src/soc/intel/cannonlake/bootblock/report_platform.c:

https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/report_platform.c@55
PS7, Line 55: const struct cpu_info* soc_get_cpu_id_table(void)
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/report_platform.c@60
PS7, Line 60: const struct mch_info* soc_get_mch_id_table(void)
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/report_platform.c@65
PS7, Line 65: const struct pch_info* soc_get_pch_id_table(void)
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/25811/7/src/soc/intel/cannonlake/bootblock/report_platform.c@70
PS7, Line 70: const struct igd_info* soc_get_igd_id_table(void)
"foo* bar" should be "foo *bar"



-- 
To view, visit https://review.coreboot.org/25811
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4397c6d599a9f4ef235755835db3f4d22f81674e
Gerrit-Change-Number: 25811
Gerrit-PatchSet: 7
Gerrit-Owner: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 13 Jun 2018 22:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180613/11f93f34/attachment.html>