[coreboot-gerrit] Change in libgfxinit[master]: gma: Introduce Generation type

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/27059 )

Change subject: gma: Introduce Generation type
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/27059/1/common/Makefile.inc
File common/Makefile.inc:

https://review.coreboot.org/#/c/27059/1/common/Makefile.inc@47
PS1, Line 47: 
missing $(call strip_quotes,...)


https://review.coreboot.org/#/c/27059/1/common/hw-gfx-gma-config.ads.template
File common/hw-gfx-gma-config.ads.template:

https://review.coreboot.org/#/c/27059/1/common/hw-gfx-gma-config.ads.template@39
PS1, Line 39: 
Introduce Gen_* booleans here already?



-- 
To view, visit https://review.coreboot.org/27059
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5061021a80cd75ee3d7996ca343e6388b22bf341
Gerrit-Change-Number: 27059
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Wed, 13 Jun 2018 20:57:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180613/27919e03/attachment.html>