[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Update DPTF table from version 1.5

John Su (Code Review) gerrit at coreboot.org
Wed Jun 13 09:14:28 CEST 2018


John Su has uploaded this change for review. ( https://review.coreboot.org/27086


Change subject: mb/google/poppy/variants/nami: Update DPTF table from version 1.5
......................................................................

mb/google/poppy/variants/nami: Update DPTF table from version 1.5

Update dptf.asl and TCC parameters from tuning of the thermal team.

BUG=b:72974136
TEST=Match the result from DPTF UI

Change-Id: Ic0ffc169ad3939cacb46824ed23999c61a23d2c4
Signed-off-by: John Su <john_su at compal.corp-partner.google.com>
---
M src/mainboard/google/poppy/variants/nami/devicetree.cb
M src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
2 files changed, 11 insertions(+), 11 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/27086/1

diff --git a/src/mainboard/google/poppy/variants/nami/devicetree.cb b/src/mainboard/google/poppy/variants/nami/devicetree.cb
index 4d912d3..902179a 100644
--- a/src/mainboard/google/poppy/variants/nami/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nami/devicetree.cb
@@ -282,7 +282,7 @@
 
 	register "speed_shift_enable" = "1"
 
-	register "tcc_offset" = "10"     # TCC of 90C
+	register "tcc_offset" = "3"     # TCC of 90C
 	register "psys_pmax" = "101"
 
 	# PCH Trip Temperature in degree C
diff --git a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
index 05d5552..af40ab9 100644
--- a/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
+++ b/src/mainboard/google/poppy/variants/nami/include/variant/acpi/dptf.asl
@@ -23,23 +23,23 @@
 
 #define DPTF_TSR0_SENSOR_ID	0
 #define DPTF_TSR0_SENSOR_NAME	"Thermal_Sensor_Remote_CPU"
-#define DPTF_TSR0_PASSIVE	81
+#define DPTF_TSR0_PASSIVE	75
 #define DPTF_TSR0_CRITICAL	125
 #define DPTF_TSR0_ACTIVE_AC0	50
 #define DPTF_TSR0_ACTIVE_AC1	47
 #define DPTF_TSR0_ACTIVE_AC2	45
-#define DPTF_TSR0_ACTIVE_AC3	43
-#define DPTF_TSR0_ACTIVE_AC4	41
+#define DPTF_TSR0_ACTIVE_AC3	42
+#define DPTF_TSR0_ACTIVE_AC4	39
 
 #define DPTF_TSR1_SENSOR_ID	1
 #define DPTF_TSR1_SENSOR_NAME	"Thermal_Sensor_Remote_PMIC"
-#define DPTF_TSR1_PASSIVE	78
+#define DPTF_TSR1_PASSIVE	75
 #define DPTF_TSR1_CRITICAL	125
 #define DPTF_TSR1_ACTIVE_AC0    50
 #define DPTF_TSR1_ACTIVE_AC1    47
 #define DPTF_TSR1_ACTIVE_AC2    45
-#define DPTF_TSR1_ACTIVE_AC3    43
-#define DPTF_TSR1_ACTIVE_AC4    41
+#define DPTF_TSR1_ACTIVE_AC3    42
+#define DPTF_TSR1_ACTIVE_AC4    39
 
 #define DPTF_ENABLE_CHARGER
 #define DPTF_ENABLE_FAN_CONTROL
@@ -63,7 +63,7 @@
 	/* Control, Trip Point, Speed, NoiseLevel, Power */
 	Package () {90,		0xFFFFFFFF,	6700,	220,	2200},
 	Package () {69,		0xFFFFFFFF,	5800,	180,	1800},
-	Package () {52,		0xFFFFFFFF,	5000,	145,	1450},
+	Package () {56,		0xFFFFFFFF,	5000,	145,	1450},
 	Package () {46,		0xFFFFFFFF,	4900,	115,	1150},
 	Package () {36,		0xFFFFFFFF,	3900,	90,	900}
 })
@@ -76,15 +76,15 @@
 		 * Source, Target, Weight, AC0, AC1, AC2, AC3, AC4, AC5, AC6,
 		 *	AC7, AC8, AC9
 		 */
-		\_SB.DPTF.TFN1, \_SB.PCI0.B0D4, 100, 90, 69, 52, 46, 36, 0, 0,
+		\_SB.DPTF.TFN1, \_SB.PCI0.B0D4, 100, 90, 69, 56, 46, 36, 0, 0,
 			0, 0, 0
 	},
 	Package () {
-		\_SB.DPTF.TFN1, \_SB.DPTF.TSR0, 100, 90, 69, 52, 46, 36, 0, 0,
+		\_SB.DPTF.TFN1, \_SB.DPTF.TSR0, 100, 90, 69, 56, 46, 36, 0, 0,
 			0, 0, 0
 	},
 	Package () {
-		\_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 69, 52, 46, 36, 0, 0,
+		\_SB.DPTF.TFN1, \_SB.DPTF.TSR1, 100, 90, 69, 56, 46, 36, 0, 0,
 			0, 0, 0
 	}
 })

-- 
To view, visit https://review.coreboot.org/27086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0ffc169ad3939cacb46824ed23999c61a23d2c4
Gerrit-Change-Number: 27086
Gerrit-PatchSet: 1
Gerrit-Owner: John Su <john_su at compal.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180613/cf28bd33/attachment-0001.html>


More information about the coreboot-gerrit mailing list