[coreboot-gerrit] Change in coreboot[master]: Revert "sb/intel/{bd82x6, ibexpeak}: Move RCBA macros to a common loca...

Wed Jun 13 00:23:05 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27038 )

Change subject: Revert "sb/intel/{bd82x6,ibexpeak}: Move RCBA macros to a common location"
......................................................................

Patch Set 2:

(32 comments)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h
File src/southbridge/intel/bd82x6x/pch.h:

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@273
PS2, Line 273: #define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x))
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@274
PS2, Line 274: #define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x))
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@275
PS2, Line 275: #define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x))
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@277
PS2, Line 277: #define RCBA_AND_OR(bits, x, and, or) \
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@278
PS2, Line 278:         RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))
code indent should use tabs where possible

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@278
PS2, Line 278:         RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))
please, no spaces at the start of a line

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@324
PS2, Line 324: #define RPFN_FNGET(reg,port)    (((reg) >> ((port) * 4)) & 7)
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@326
PS2, Line 326: #define RPFN_FNSET(port,func)   (((func) & 7) << ((port) * 4))
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@413
PS2, Line 413: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@413
PS2, Line 413: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@413
PS2, Line 413: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@413
PS2, Line 413: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@413
PS2, Line 413: #define DIR_ROUTE(x,a,b,c,d) \
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@414
PS2, Line 414:   RCBA16(x) = (((d) << DIR_IDR) | ((c) << DIR_ICR) | \
please, no spaces at the start of a line

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@415
PS2, Line 415:                ((b) << DIR_IBR) | ((a) << DIR_IAR))
code indent should use tabs where possible

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/bd82x6x/pch.h@415
PS2, Line 415:                ((b) << DIR_IBR) | ((a) << DIR_IAR))
please, no spaces at the start of a line

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h
File src/southbridge/intel/ibexpeak/pch.h:

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@245
PS2, Line 245: #define RCBA8(x) *((volatile u8 *)(DEFAULT_RCBA + x))
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@246
PS2, Line 246: #define RCBA16(x) *((volatile u16 *)(DEFAULT_RCBA + x))
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@247
PS2, Line 247: #define RCBA32(x) *((volatile u32 *)(DEFAULT_RCBA + x))
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@249
PS2, Line 249: #define RCBA_AND_OR(bits, x, and, or) \
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@250
PS2, Line 250:         RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))
code indent should use tabs where possible

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@250
PS2, Line 250:         RCBA##bits(x) = ((RCBA##bits(x) & (and)) | (or))
please, no spaces at the start of a line

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@296
PS2, Line 296: #define RPFN_FNGET(reg,port)    (((reg) >> ((port) * 4)) & 7)
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@298
PS2, Line 298: #define RPFN_FNSET(port,func)   (((func) & 7) << ((port) * 4))
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@386
PS2, Line 386: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@386
PS2, Line 386: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@386
PS2, Line 386: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@386
PS2, Line 386: #define DIR_ROUTE(x,a,b,c,d) \
space required after that ',' (ctx:VxV)

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@386
PS2, Line 386: #define DIR_ROUTE(x,a,b,c,d) \
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@387
PS2, Line 387:   RCBA32(x) = (((d) << DIR_IDR) | ((c) << DIR_ICR) | \
please, no spaces at the start of a line

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@388
PS2, Line 388:                ((b) << DIR_IBR) | ((a) << DIR_IAR))
code indent should use tabs where possible

https://review.coreboot.org/#/c/27038/2/src/southbridge/intel/ibexpeak/pch.h@388
PS2, Line 388:                ((b) << DIR_IBR) | ((a) << DIR_IAR))
please, no spaces at the start of a line

-- 
To view, visit https://review.coreboot.org/27038
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbf4db8590e60573c8c11385835e0231cf8d63e6
Gerrit-Change-Number: 27038
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 22:23:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180612/f0006703/attachment.html>