[coreboot-gerrit] Change in coreboot[master]: src: Get rid of device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Jun 12 22:26:15 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27036 )

Change subject: src: Get rid of device_t
......................................................................


Patch Set 2:

(6 comments)

https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c
File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:

https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@75
PS2, Line 75: 		struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1));
line over 80 characters


https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@97
PS2, Line 97: 		struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1));
line over 80 characters


https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@134
PS2, Line 134: 		struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1));
line over 80 characters


https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@318
PS2, Line 318: 		struct device *dev_fn1 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 1));
line over 80 characters


https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@319
PS2, Line 319: 		struct device *dev_fn2 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 2));
line over 80 characters


https://review.coreboot.org/#/c/27036/2/src/northbridge/amd/amdmct/mct_ddr3/s3utils.c@320
PS2, Line 320: 		struct device *dev_fn3 = dev_find_slot(0, PCI_DEVFN(0x18 + node, 3));
line over 80 characters



-- 
To view, visit https://review.coreboot.org/27036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6adc0429ae9ecc8f726d6167a6458d9333dc515f
Gerrit-Change-Number: 27036
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 20:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180612/026c1bcd/attachment.html>


More information about the coreboot-gerrit mailing list