[coreboot-gerrit] Change in coreboot[master]: x86 smm: Increase SMM stack size to 2K

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/27033 )

Change subject: x86 smm: Increase SMM stack size to 2K
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/27033/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/27033/2//COMMIT_MSG@7
PS2, Line 7: x86 smm: Increase SMM stack size to 2K
           : 
           : GSMI Set Event Log is taking more than 1K in stack. This causes the
           : stack to overflow into the adjacent stack. This has the side effect of
           : causing any CPU waiting for the SMI handler to complete to crash when
           : the lock is unlocked because the return pointer has been smashed.
           : 
           : BUG=b:80539294
           : TEST=built on grunt and tested by running `halt` from the OS.
Probably want to update this now:

 cpu/x86: Make SMM stack size configurable



-- 
To view, visit https://review.coreboot.org/27033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib170c7d03909ef3d20831726b285178a75007b06
Gerrit-Change-Number: 27033
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 16:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180612/3694a037/attachment.html>