[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nocturne: config GPP_B4 for FCAM_PWR_EN

Nick Vaccaro (Code Review) gerrit at coreboot.org
Tue Jun 12 08:43:25 CEST 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/27022


Change subject: mb/google/poppy/variants/nocturne: config GPP_B4 for FCAM_PWR_EN
......................................................................

mb/google/poppy/variants/nocturne: config GPP_B4 for FCAM_PWR_EN

FCAM_PWR_EN signal is changing to connect to GPP_B4 instead of
GPP_D8 as it needs a 3.3v gpio to provide enough power to also
directly power the camera LED.

BUG=b:79667559,b:78122599
BRANCH=none
TEST=none

Change-Id: Ie875ced45dfa2aa7069851004edde8f77329df34
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/27022/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index ad7f963..77659dc 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -71,8 +71,8 @@
 	PAD_CFG_NC(GPP_B2),
 	/* B3  : CPU_GP2 ==> NC */
 	PAD_CFG_NC(GPP_B3),
-	/* B4  : CPU_GP3 ==> NC */
-	PAD_CFG_NC(GPP_B4),
+	/* B4  : CPU_GP3 ==> FCAM_PWR_EN */
+	PAD_CFG_GPO(GPP_B4, 0, DEEP),
 	/* B5  : SRCCLKREQ0# ==> NC */
 	PAD_CFG_NC(GPP_B5),
 	/* B6  : SRCCLKREQ1# ==> WLAN_PCIE_CLKREQ_L */

-- 
To view, visit https://review.coreboot.org/27022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie875ced45dfa2aa7069851004edde8f77329df34
Gerrit-Change-Number: 27022
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180612/f332aa18/attachment.html>


More information about the coreboot-gerrit mailing list