[coreboot-gerrit] Change in coreboot[master]: google/grunt: Enable keyboard backlight for careena specific SKU
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Tue Jun 12 07:29:24 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27021 )
Change subject: google/grunt: Enable keyboard backlight for careena specific SKU
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27021/1/src/mainboard/google/kahlee/variants/baseboard/romstage.c
File src/mainboard/google/kahlee/variants/baseboard/romstage.c:
https://review.coreboot.org/#/c/27021/1/src/mainboard/google/kahlee/variants/baseboard/romstage.c@35
PS1, Line 35: /* Based on SKU, turn on keyboard backlight to show system is booting */
line over 80 characters
https://review.coreboot.org/#/c/27021/1/src/mainboard/google/kahlee/variants/baseboard/romstage.c@36
PS1, Line 36: switch (sku) {
switch and case should be at the same indent
--
To view, visit https://review.coreboot.org/27021
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d302c4f50528b0e6b7ef4d990f342a69cff34f5
Gerrit-Change-Number: 27021
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 12 Jun 2018 05:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180612/b277d99b/attachment.html>
More information about the coreboot-gerrit
mailing list