[coreboot-gerrit] Change in coreboot[master]: src: Move constant to the right side of comparison

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27015 )

Change subject: src: Move constant to the right side of comparison
......................................................................


Patch Set 5:

(9 comments)

https://review.coreboot.org/#/c/27015/5/util/msrtool/linux.c
File util/msrtool/linux.c:

https://review.coreboot.org/#/c/27015/5/util/msrtool/linux.c@71
PS5, Line 71: 	return ret ==0;
spaces required around that '==' (ctx:WxV)


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c
File util/msrtool/msrtool.c:

https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@128
PS5, Line 128: 			if ((fin = fopen(streamfn, "r")) == NULL) {
do not use assignment in if condition


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@136
PS5, Line 136: 			if ((fdout = mkstemp(tmpfn)) == -1) {
do not use assignment in if condition


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@140
PS5, Line 140: 			if ((fout = fdopen(fdout, "w")) == NULL) {
do not use assignment in if condition


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@145
PS5, Line 145: 			if ((fout = fopen(streamfn, "w")) == NULL) {
do not use assignment in if condition


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@216
PS5, Line 216: 	else if ((fin = fopen(difffn, "r")) == NULL) {
do not use assignment in if condition


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrtool.c@226
PS5, Line 226: 		for (len = strlen(m1start) - 1; strchr("\r\n", m1start[len]) != NULL; --len)
line over 80 characters


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrutils.c
File util/msrtool/msrutils.c:

https://review.coreboot.org/#/c/27015/5/util/msrtool/msrutils.c@325
PS5, Line 325: 	if (m= NULL) {
spaces required around that '=' (ctx:VxW)


https://review.coreboot.org/#/c/27015/5/util/msrtool/msrutils.c@325
PS5, Line 325: 	if (m= NULL) {
do not use assignment in if condition



-- 
To view, visit https://review.coreboot.org/27015
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d35a3643600f81a6da7e0af99c935ebd1c2fc7
Gerrit-Change-Number: 27015
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi at google.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 10:05:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180611/1f1cdd1a/attachment.html>