[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Turn on backlight for all SKUs
Martin Roth (Code Review)
gerrit at coreboot.org
Fri Jun 8 20:49:07 CEST 2018
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/26969 )
Change subject: mainboard/google/kahlee: Turn on backlight for all SKUs
......................................................................
mainboard/google/kahlee: Turn on backlight for all SKUs
Careena uses a different keyboard backlight method, so let the EC
handle the different SKUs and backlight methods.
BUG=b:80106042
TEST=None
Change-Id: I47f7a9ac13538f0216fbb0f64fdd22f66097820c
Signed-off-by: Martin Roth <martinroth at google.com>
Reviewed-on: https://review.coreboot.org/26969
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Raul Rangel <rrangel at chromium.org>
---
M src/mainboard/google/kahlee/variants/baseboard/romstage.c
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Raul Rangel: Looks good to me, approved
diff --git a/src/mainboard/google/kahlee/variants/baseboard/romstage.c b/src/mainboard/google/kahlee/variants/baseboard/romstage.c
index 2b8baf8..f87a9d6 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/romstage.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/romstage.c
@@ -18,9 +18,6 @@
void variant_romstage_entry(int s3_resume)
{
- uint32_t sku = google_chromeec_get_sku_id();
-
- /* Based on SKU, turn on keyboard backlight to show system is booting */
- if (sku <= 6 && !s3_resume)
+ if (!s3_resume)
google_chromeec_kbbacklight(75);
}
--
To view, visit https://review.coreboot.org/26969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47f7a9ac13538f0216fbb0f64fdd22f66097820c
Gerrit-Change-Number: 26969
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180608/99c7bffb/attachment.html>
More information about the coreboot-gerrit
mailing list