[coreboot-gerrit] Change in coreboot[master]: mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Jun 8 19:03:48 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26984 )
Change subject: mainboard: Use pci_devfn_t or pnp_devfn_t instead of device_t
......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/#/c/26984/2/src/mainboard/google/butterfly/chromeos.c
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/google/butterfly/chromeos.c@40
PS2, Line 40: pci_devfn_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/26984/2/src/mainboard/google/parrot/chromeos.c
File src/mainboard/google/parrot/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/google/parrot/chromeos.c@37
PS2, Line 37: pci_devfn_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/26984/2/src/mainboard/google/stout/chromeos.c
File src/mainboard/google/stout/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/google/stout/chromeos.c@104
PS2, Line 104: struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/26984/2/src/mainboard/intel/baskingridge/chromeos.c
File src/mainboard/intel/baskingridge/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/intel/baskingridge/chromeos.c@32
PS2, Line 32: pci_devfn_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/26984/2/src/mainboard/intel/emeraldlake2/chromeos.c
File src/mainboard/intel/emeraldlake2/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/intel/emeraldlake2/chromeos.c@32
PS2, Line 32: pci_devfn_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/26984/2/src/mainboard/samsung/lumpy/chromeos.c
File src/mainboard/samsung/lumpy/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/samsung/lumpy/chromeos.c@43
PS2, Line 43: pci_devfn_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/26984/2/src/mainboard/samsung/stumpy/chromeos.c
File src/mainboard/samsung/stumpy/chromeos.c:
https://review.coreboot.org/#/c/26984/2/src/mainboard/samsung/stumpy/chromeos.c@40
PS2, Line 40: pci_devfn_t dev = dev_find_slot(0, PCI_DEVFN(0x1f,0));
space required after that ',' (ctx:VxV)
--
To view, visit https://review.coreboot.org/26984
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0ae3972eacc97ae154dad4fafd171aa1f38683a
Gerrit-Change-Number: 26984
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 17:03:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180608/61824763/attachment.html>
More information about the coreboot-gerrit
mailing list