[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint: Get rid of device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Fri Jun 8 17:30:39 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26974 )

Change subject: sb/intel/lynxpoint: Get rid of device_t
......................................................................


Patch Set 2:

(8 comments)

https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/lpc.c
File src/southbridge/intel/lynxpoint/lpc.c:

https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/lpc.c@741
PS2, Line 741: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/lpc.c@741
PS2, Line 741: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/pci.c
File src/southbridge/intel/lynxpoint/pci.c:

https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/pci.c@107
PS2, Line 107: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/pci.c@107
PS2, Line 107: static void set_subsystem(struct device *dev, unsigned vendor, unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/pcie.c
File src/southbridge/intel/lynxpoint/pcie.c:

https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/pcie.c@718
PS2, Line 718: static void pcie_set_subsystem(struct device *dev, unsigned vendor,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/pcie.c@719
PS2, Line 719: 			       unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/sata.c
File src/southbridge/intel/lynxpoint/sata.c:

https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/sata.c@325
PS2, Line 325: static void sata_set_subsystem(struct device *dev, unsigned vendor,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/26974/2/src/southbridge/intel/lynxpoint/sata.c@326
PS2, Line 326: 			       unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'



-- 
To view, visit https://review.coreboot.org/26974
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I064ff5e76dd95c1770cd24139195b2a5fff2d382
Gerrit-Change-Number: 26974
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 08 Jun 2018 15:30:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180608/32a25422/attachment.html>


More information about the coreboot-gerrit mailing list