[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Fix GPIO to GPE mappings in devicetree

Furquan Shaikh (Code Review) gerrit at coreboot.org
Fri Jun 8 00:42:44 CEST 2018


Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/26971 )

Change subject: mb/google/octopus: Fix GPIO to GPE mappings in devicetree
......................................................................

mb/google/octopus: Fix GPIO to GPE mappings in devicetree

Change b41ae2 (mb/google/octopus: Enable wake-over-wifi for octopus
variants) changed the GPE mappings to accomodate for WiFi wake
pin. However, this resulted in TPM interrupt pin being removed from
the GPIO to GPE mapping. Since we do not support true interrupts in
coreboot, GPE_STS registers are used to identify if an interrupt has
triggered. Change in GPE mapping resulted in this information to be
lost when talking to TPM thus resulting in "Timeout wait for tpm
irq".

This change fixes the above issue by assigning GPIO block for TPM
interrupt back to DW1 and moving GPIO block for wake-over-wifi pin to
DW3. DW3 was mapped to NW_31_0 which only has debug header pins and
CNVI pins (none of them are used for reading GPE_STS or as wake
sources).

BUG=b:109824918
TEST=Verified that there are no "Timeout wait for tpm irq" messages
when talking to TPM.

Change-Id: I30768177a838a684948f7485d760c8b83c3190f7
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/octopus/variants/baseboard/devicetree.cb
M src/mainboard/google/octopus/variants/bip/devicetree.cb
2 files changed, 23 insertions(+), 6 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/26971/2
-- 
To view, visit https://review.coreboot.org/26971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30768177a838a684948f7485d760c8b83c3190f7
Gerrit-Change-Number: 26971
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180607/62d67e44/attachment.html>


More information about the coreboot-gerrit mailing list