[coreboot-gerrit] Change in coreboot[master]: [WIP]mainboard/lenovo/t410: Add new port

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/11791 )

Change subject: [WIP]mainboard/lenovo/t410: Add new port
......................................................................


Patch Set 6:

(13 comments)

https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/mainboard.c
File src/mainboard/lenovo/t410/mainboard.c:

https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/mainboard.c@42
PS6, Line 42: 	{1, 1, 1000, {0x7f, 1, 2, {0}, 1, 0}},
space required after that close brace '}'


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/mainboard.c@43
PS6, Line 43: 	{2, 1, 500, {0x01, 8, 0, {0}, DEFAULT_PMBASE + LV2, 0}},
space required after that close brace '}'


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/mainboard.c@44
PS6, Line 44: 	{2, 17, 250, {0x01, 8, 0, {0}, DEFAULT_PMBASE + LV3, 0}},
space required after that close brace '}'


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/romstage.c
File src/mainboard/lenovo/t410/romstage.c:

https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/romstage.c@65
PS6, Line 65: 			  (pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) & ~2) | 1);
line over 80 characters


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/romstage.c@141
PS6, Line 141: 	unsigned i;
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/romstage.c@288
PS6, Line 288: 				  pci_read_config8(PCH_LPC_DEV, GEN_PMCON_3) | 2);
line over 80 characters


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c
File src/mainboard/lenovo/t410/smihandler.c:

https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@50
PS6, Line 50: 	switch (smif) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@53
PS6, Line 53: 			udelay(250000);
long udelay - prefer mdelay; see arch/arm/include/asm/delay.h


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@79
PS6, Line 79: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
do not use assignment in if condition


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@87
PS6, Line 87: 	if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
do not use assignment in if condition


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@103
PS6, Line 103: 	switch (event) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@140
PS6, Line 140: 	switch (data) {
switch and case should be at the same indent


https://review.coreboot.org/#/c/11791/6/src/mainboard/lenovo/t410/smihandler.c@164
PS6, Line 164: 			/* we have to use port 0x62/0x66, as 0x1600/0x1604 doesn't
line over 80 characters



-- 
To view, visit https://review.coreboot.org/11791
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9d872e643dd242e925bfb46d18076e6ad100995
Gerrit-Change-Number: 11791
Gerrit-PatchSet: 6
Gerrit-Owner: Nicolas Reinecke <nr at das-labor.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 17:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180607/f5621494/attachment.html>