[coreboot-gerrit] Change in coreboot[master]: {arch, commonlib, cpu, device, drivers, lib, nb, sb}: Use "foo *bar" instead...

Thu Jun 7 12:02:11 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26942 )

Change subject: {arch,commonlib,cpu,device,drivers,lib,nb,sb}: Use "foo *bar" instead of "foo* bar"
......................................................................

Patch Set 5:

(29 comments)

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h
File src/device/oprom/yabel/compat/of.h:

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@38
PS5, Line 38: #define p32cast (int) (unsigned long) (void *)
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@62
PS5, Line 62: int of_read(ihandle_t , void *, int);
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@62
PS5, Line 62: int of_read(ihandle_t , void *, int);
function definition argument 'ihandle_t' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@62
PS5, Line 62: int of_read(ihandle_t , void *, int);
function definition argument 'void *' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@62
PS5, Line 62: int of_read(ihandle_t , void *, int);
function definition argument 'int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@63
PS5, Line 63: int of_write(ihandle_t, void *, int);
function definition argument 'ihandle_t' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@63
PS5, Line 63: int of_write(ihandle_t, void *, int);
function definition argument 'void *' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@63
PS5, Line 63: int of_write(ihandle_t, void *, int);
function definition argument 'int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@64
PS5, Line 64: int of_seek(ihandle_t, int, int);
function definition argument 'ihandle_t' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@64
PS5, Line 64: int of_seek(ihandle_t, int, int);
function definition argument 'int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@64
PS5, Line 64: int of_seek(ihandle_t, int, int);
function definition argument 'int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@66
PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int );
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@66
PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@66
PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int );
function definition argument 'void *' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@66
PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int );
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@66
PS5, Line 66: void * of_claim(void *, unsigned int, unsigned int );
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@72
PS5, Line 72: int vpd_read(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@72
PS5, Line 72: int vpd_read(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@72
PS5, Line 72: int vpd_read(unsigned int, unsigned int, char *);
function definition argument 'char *' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@73
PS5, Line 73: int vpd_write(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@73
PS5, Line 73: int vpd_write(unsigned int, unsigned int, char *);
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@73
PS5, Line 73: int vpd_write(unsigned int, unsigned int, char *);
function definition argument 'char *' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@74
PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short );
space prohibited before that close parenthesis ')'

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@74
PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short );
function definition argument 'char *' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@74
PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short );
function definition argument 'unsigned int' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/device/oprom/yabel/compat/of.h@74
PS5, Line 74: int write_mm_log(char *, unsigned int, unsigned short );
function definition argument 'unsigned short' should also have an identifier name

https://review.coreboot.org/#/c/26942/5/src/northbridge/amd/amdht/ht_wrapper.c
File src/northbridge/amd/amdht/ht_wrapper.c:

https://review.coreboot.org/#/c/26942/5/src/northbridge/amd/amdht/ht_wrapper.c@58
PS5, Line 58: static const char *event_class_string_decodes[] = {
static const char * array should probably be static const char * const

https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb800/late.c
File src/southbridge/amd/cimx/sb800/late.c:

https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb800/late.c@46
PS5, Line 46:  * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void *pConfig)
line over 80 characters

https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb900/late.c
File src/southbridge/amd/cimx/sb900/late.c:

https://review.coreboot.org/#/c/26942/5/src/southbridge/amd/cimx/sb900/late.c@41
PS5, Line 41:  * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void * pConfig)
line over 80 characters

-- 
To view, visit https://review.coreboot.org/26942
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4118c5c5d70719ad7dc5f9ff9f86d93fa498ac
Gerrit-Change-Number: 26942
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 10:02:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180607/3ff2ff6e/attachment.html>