[coreboot-gerrit] Change in coreboot[master]: {arch, commonlib, cpu, device, drivers, lib, nb, sb}: Use "foo *bar" instead...

Thu Jun 7 11:39:28 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26942 )

Change subject: {arch,commonlib,cpu,device,drivers,lib,nb,sb}: Use "foo *bar" instead of "foo* bar"
......................................................................

Patch Set 2:

(44 comments)

https://review.coreboot.org/#/c/26942/2/src/arch/riscv/include/mcall.h
File src/arch/riscv/include/mcall.h:

https://review.coreboot.org/#/c/26942/2/src/arch/riscv/include/mcall.h@59
PS2, Line 59: #define OTHER_HLS(id) ((hls_t*)((void *)HLS() + RISCV_PGSIZE * ((id) - HLS()->hart_id)))
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/arch/riscv/include/mcall.h@59
PS2, Line 59: #define OTHER_HLS(id) ((hls_t*)((void *)HLS() + RISCV_PGSIZE * ((id) - HLS()->hart_id)))
"(foo*)" should be "(foo *)"

https://review.coreboot.org/#/c/26942/2/src/arch/riscv/trap_handler.c
File src/arch/riscv/trap_handler.c:

https://review.coreboot.org/#/c/26942/2/src/arch/riscv/trap_handler.c@204
PS2, Line 204: 		void * badAddress = (void *) tf->badvaddr;
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/arch/riscv/trap_handler.c@232
PS2, Line 232: 		void * badAddress = (void *) tf->badvaddr;
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/cpu/amd/family_10h-family_15h/init_cpus.c
File src/cpu/amd/family_10h-family_15h/init_cpus.c:

https://review.coreboot.org/#/c/26942/2/src/cpu/amd/family_10h-family_15h/init_cpus.c@380
PS2, Line 380: 	void * lower_stack_region_boundary = (void *)(bsp_stack_region_lower_boundary - max_ap_stack_region_size);
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/cpu/amd/family_10h-family_15h/init_cpus.c@380
PS2, Line 380: 	void * lower_stack_region_boundary = (void *)(bsp_stack_region_lower_boundary - max_ap_stack_region_size);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/device/oprom/include/x86emu/regs.h
File src/device/oprom/include/x86emu/regs.h:

https://review.coreboot.org/#/c/26942/2/src/device/oprom/include/x86emu/regs.h@309
PS2, Line 309: 	void *        	private;
please, no space before tabs

https://review.coreboot.org/#/c/26942/2/src/device/oprom/include/x86emu/regs.h@309
PS2, Line 309: 	void *        	private;
"foo *        	bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h
File src/device/oprom/yabel/compat/of.h:

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@38
PS2, Line 38: #define p32cast (int) (unsigned long) (void *)
Macros with complex values should be enclosed in parentheses

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@62
PS2, Line 62: int of_read (ihandle_t , void *, int);
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@62
PS2, Line 62: int of_read (ihandle_t , void *, int);
space prohibited before that ',' (ctx:WxW)

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@62
PS2, Line 62: int of_read (ihandle_t , void *, int);
function definition argument 'ihandle_t' should also have an identifier name

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@62
PS2, Line 62: int of_read (ihandle_t , void *, int);
function definition argument 'void *' should also have an identifier name

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@62
PS2, Line 62: int of_read (ihandle_t , void *, int);
function definition argument 'int' should also have an identifier name

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@63
PS2, Line 63: int of_write (ihandle_t, void *, int);
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@63
PS2, Line 63: int of_write (ihandle_t, void *, int);
function definition argument 'ihandle_t' should also have an identifier name

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@63
PS2, Line 63: int of_write (ihandle_t, void *, int);
function definition argument 'void *' should also have an identifier name

https://review.coreboot.org/#/c/26942/2/src/device/oprom/yabel/compat/of.h@63
PS2, Line 63: int of_write (ihandle_t, void *, int);
function definition argument 'int' should also have an identifier name

https://review.coreboot.org/#/c/26942/2/src/drivers/aspeed/common/aspeed_coreboot.h
File src/drivers/aspeed/common/aspeed_coreboot.h:

https://review.coreboot.org/#/c/26942/2/src/drivers/aspeed/common/aspeed_coreboot.h@76
PS2, Line 76: 	void * ptr = malloc(size);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/drivers/intel/fsp1_0/fsp_util.c
File src/drivers/intel/fsp1_0/fsp_util.c:

https://review.coreboot.org/#/c/26942/2/src/drivers/intel/fsp1_0/fsp_util.c@103
PS2, Line 103: volatile u8 *find_fsp ()
space prohibited between function name and open parenthesis '('

https://review.coreboot.org/#/c/26942/2/src/drivers/intel/fsp1_0/fsp_util.c@224
PS2, Line 224: 		FspHobListPtr = (void *)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/drivers/intel/fsp1_0/fsp_util.c@224
PS2, Line 224: 		FspHobListPtr = (void *)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));
"(foo*)" should be "(foo *)"

https://review.coreboot.org/#/c/26942/2/src/drivers/intel/fsp1_0/fsp_util.c@297
PS2, Line 297: 	FspHobListPtr = (void *)*((u32*) cbmem_find(CBMEM_ID_HOB_POINTER));
"(foo*)" should be "(foo *)"

https://review.coreboot.org/#/c/26942/2/src/drivers/xgi/common/xgi_coreboot.c
File src/drivers/xgi/common/xgi_coreboot.c:

https://review.coreboot.org/#/c/26942/2/src/drivers/xgi/common/xgi_coreboot.c@133
PS2, Line 133: 	xgifb_info->video_vbase = hw_info->pjVideoMemoryAddress = (void *)(intptr_t)xgifb_info->video_base;
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/northbridge/amd/amdht/ht_wrapper.c
File src/northbridge/amd/amdht/ht_wrapper.c:

https://review.coreboot.org/#/c/26942/2/src/northbridge/amd/amdht/ht_wrapper.c@58
PS2, Line 58: static const char *event_class_string_decodes[] = {
static const char * array should probably be static const char * const

https://review.coreboot.org/#/c/26942/2/src/northbridge/amd/amdht/ht_wrapper.c@93
PS2, Line 93: static const char *event_string_decode(uint32_t event) {
open brace '{' following function declarations go on the next line

https://review.coreboot.org/#/c/26942/2/src/northbridge/amd/pi/agesawrapper.c
File src/northbridge/amd/pi/agesawrapper.c:

https://review.coreboot.org/#/c/26942/2/src/northbridge/amd/pi/agesawrapper.c@292
PS2, Line 292: 	const void * agesa;
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/northbridge/intel/gm45/iommu.c
File src/northbridge/intel/gm45/iommu.c:

https://review.coreboot.org/#/c/26942/2/src/northbridge/intel/gm45/iommu.c@57
PS2, Line 57: 		void * bar = (void *)pci_read_config32(igd, PCI_BASE_ADDRESS_0);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/northbridge/intel/nehalem/raminit.c
File src/northbridge/intel/nehalem/raminit.c:

https://review.coreboot.org/#/c/26942/2/src/northbridge/intel/nehalem/raminit.c@2297
PS2, Line 2297:        u8 *res_low, u8 *res_high, u8 val)
please, no spaces at the start of a line

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/Amd.h
File src/southbridge/amd/cimx/sb800/Amd.h:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/Amd.h@64
PS2, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr);
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/Amd.h@64
PS2, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/Amd.h@65
PS2, Line 65: typedef AGESA_STATUS (*IMAGE_ENTRY) (IN OUT void * ConfigPtr);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/Amd.h@66
PS2, Line 66: typedef AGESA_STATUS (*MODULE_ENTRY) (IN OUT void * ConfigPtr);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/AmdSbLib.h
File src/southbridge/amd/cimx/sb800/AmdSbLib.h:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/AmdSbLib.h@31
PS2, Line 31: typedef void (*CIM_IMAGE_ENTRY) (void * pConfig);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/late.c
File src/southbridge/amd/cimx/sb800/late.c:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/late.c@46
PS2, Line 46:  * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void * pConfig)
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb800/late.c@53
PS2, Line 53: static u32 sb800_callout_entry(u32 func, u32 data, void * config)
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/Amd.h
File src/southbridge/amd/cimx/sb900/Amd.h:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/Amd.h@64
PS2, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr);
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/Amd.h@64
PS2, Line 64: typedef AGESA_STATUS (*CALLOUT_ENTRY) (unsigned int Param1, unsigned int Param2, void * ConfigPtr);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/Amd.h@65
PS2, Line 65: typedef AGESA_STATUS (*IMAGE_ENTRY) (IN OUT void * ConfigPtr);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/Amd.h@66
PS2, Line 66: typedef AGESA_STATUS (*MODULE_ENTRY) (IN OUT void * ConfigPtr);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/AmdSbLib.h
File src/southbridge/amd/cimx/sb900/AmdSbLib.h:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/AmdSbLib.h@31
PS2, Line 31: typedef void (*CIM_IMAGE_ENTRY) (void * pConfig);
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/late.c
File src/southbridge/amd/cimx/sb900/late.c:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/late.c@41
PS2, Line 41:  * prototype UINT32 (*SBCIM_HOOK_ENTRY)(UINT32 Param1, UINT32 Param2, void * pConfig)
line over 80 characters

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/cimx/sb900/late.c@48
PS2, Line 48: u32 sb900_callout_entry(u32 func, u32 data, void * config)
"foo * bar" should be "foo *bar"

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/sr5650/sr5650.c
File src/southbridge/amd/sr5650/sr5650.c:

https://review.coreboot.org/#/c/26942/2/src/southbridge/amd/sr5650/sr5650.c@339
PS2, Line 339: 		mmio_base = (void *)(pci_read_config32(iommu_dev, 0x44) & 0xffffc000);
line over 80 characters

-- 
To view, visit https://review.coreboot.org/26942
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4118c5c5d70719ad7dc5f9ff9f86d93fa498ac
Gerrit-Change-Number: 26942
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 09:39:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180607/225b64b4/attachment.html>