[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable low power S0Idle capability

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26940 )

Change subject: soc/intel/skylake: Enable low power S0Idle capability
......................................................................


Patch Set 1:

(9 comments)

https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c
File src/soc/intel/skylake/acpi.c:

https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@237
PS1, Line 237:         const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC);
code indent should use tabs where possible


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@237
PS1, Line 237:         const struct device *dev = dev_find_slot(0, PCH_DEVFN_LPC);
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@238
PS1, Line 238:         const struct soc_intel_skylake_config *config = dev->chip_info;
code indent should use tabs where possible


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@238
PS1, Line 238:         const struct soc_intel_skylake_config *config = dev->chip_info;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@287
PS1, Line 287:         if(config->s0ix_enable)
code indent should use tabs where possible


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@287
PS1, Line 287:         if(config->s0ix_enable)
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@287
PS1, Line 287:         if(config->s0ix_enable)
space required before the open parenthesis '('


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@288
PS1, Line 288:                 fadt->flags |= ACPI_FADT_LOW_PWR_IDLE_S0;
code indent should use tabs where possible


https://review.coreboot.org/#/c/26940/1/src/soc/intel/skylake/acpi.c@288
PS1, Line 288:                 fadt->flags |= ACPI_FADT_LOW_PWR_IDLE_S0;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/26940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8a86118232a66e7466d5b8116eff6087b51210
Gerrit-Change-Number: 26940
Gerrit-PatchSet: 1
Gerrit-Owner: Rajneesh Bhardwaj <rajneesh.bhardwaj at intel.com>
Gerrit-Reviewer: Haridhar Kalvala <haridhar.kalvala at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 07 Jun 2018 08:55:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180607/cf700dae/attachment.html>