[coreboot-gerrit] Change in coreboot[master]: util/sconfig: Re-factor device structure in parse tree

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26800 )

Change subject: util/sconfig: Re-factor device structure in parse tree
......................................................................


Patch Set 8:

(12 comments)

https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c
File util/sconfig/main.c:

https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@45
PS8, Line 45:  *                 +------------------------+                +----------------------+
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@46
PS8, Line 46:  *                 |                        |                |  Mainboard           |
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@47
PS8, Line 47:  *       +---------+ Root device (root_dev) +--------------->+  instance            +
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@48
PS8, Line 48:  *       |         |                        | chip_instance  |  (mainboard_instance)|
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@49
PS8, Line 49:  *       |         +------------------------+                |                      |
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@50
PS8, Line 50:  *       |                      |                            +----------------------+
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@68
PS8, Line 68:  *                                                             +-------+----------+
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@69
PS8, Line 69:  *                                                             |                  |
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@70
PS8, Line 70:  *                                                             |  Mainboard chip  +----------->X (new chips will be
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@71
PS8, Line 71:  *                                                             | (mainboard_chip) |               added here)
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@72
PS8, Line 72:  *                                                             |                  |
line over 80 characters


https://review.coreboot.org/#/c/26800/8/util/sconfig/main.c@73
PS8, Line 73:  *                                                             +------------------+
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26800
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8c8a73a247e8e992ab6b1b2cc3131e06fa2e5a1
Gerrit-Change-Number: 26800
Gerrit-PatchSet: 8
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 23:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/7004e0df/attachment.html>