[coreboot-gerrit] Change in coreboot[master]: util/intelvbttool: Rewrite tool

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18902 )

Change subject: util/intelvbttool: Rewrite tool
......................................................................


Patch Set 13:

(8 comments)

https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c
File util/intelvbttool/intelvbttool.c:

https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@421
PS13, Line 421: 	struct fileobject* fo = malloc_fo(size);
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@773
PS13, Line 773: 	        (const struct vbt_header *)fo->data;
code indent should use tabs where possible


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@808
PS13, Line 808: 	/* Duplicate fo as caller is owner of fo and remalloc frees the object */
line over 80 characters


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@845
PS13, Line 845: 	if (oh->size == 0 || oh->size > 0x80|| oh->size * 512 > fo->size) {
spaces required around that '||' (ctx:VxW)


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@855
PS13, Line 855: 		} else {
else is not generally useful after a break or return


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@867
PS13, Line 867: 		pcir = (const optionrom_pcir_t *)((const u8 *)oh + oh->pcir_offset);
line over 80 characters


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@924
PS13, Line 924: 		const struct fileobject* fo_vbt = malloc_fo_sub(fo, i);
"foo* bar" should be "foo *bar"


https://review.coreboot.org/#/c/18902/13/util/intelvbttool/intelvbttool.c@964
PS13, Line 964: 	bdb = (const struct bdb_header *)((const char *)head + head->bdb_offset);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/18902
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cbde042c7f5632f36648419becd23e248ba6f76
Gerrit-Change-Number: 18902
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Samuel Holland <samuel at sholland.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Vladimir Serbinenko <phcoder at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 16:35:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/578323b9/attachment.html>