[coreboot-gerrit] Change in coreboot[master]: soc/intel/{glk, apl} and mainboards: Configure LPC_CLKRUN# pin as GPIO...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23742 )

Change subject: soc/intel/{glk,apl} and mainboards: Configure LPC_CLKRUN# pin as GPIO for S0ix
......................................................................


Patch Set 10:

(4 comments)

https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/variants/baseboard/gpio.c@213
PS10, Line 213: 	 * GPIO_154 - LPC_CLKRUN# has a native function for LPC but not for eSPI.
line over 80 characters


https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/variants/baseboard/gpio.c@214
PS10, Line 214: 	 * Nonetheless if we use eSPI, it should be configured as a GPIO and kept
line over 80 characters


https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:

https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/variants/bip/gpio.c@212
PS10, Line 212: 	 * GPIO_154 - LPC_CLKRUN# has a native function for LPC but not for eSPI.
line over 80 characters


https://review.coreboot.org/#/c/23742/10/src/mainboard/google/octopus/variants/bip/gpio.c@213
PS10, Line 213: 	 * Nonetheless if we use eSPI, it should be configured as a GPIO and kept
line over 80 characters



-- 
To view, visit https://review.coreboot.org/23742
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1013fee638a3b7a91469736efc0c25a1597fa
Gerrit-Change-Number: 23742
Gerrit-PatchSet: 10
Gerrit-Owner: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Shamile Khan <shamile.khan at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 07:02:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/8337dc42/attachment.html>