[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Update GPIOs as per latest schematics

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26874 )

Change subject: mb/google/octopus: Update GPIOs as per latest schematics
......................................................................


Patch Set 1:

(7 comments)

https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:

https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@79
PS1, Line 79: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PCH_I2C_PEN_SDA */
line over 80 characters


https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@80
PS1, Line 80: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* PCH_I2C_PEN_SCL */
line over 80 characters


https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@198
PS1, Line 198: 	PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */
line over 80 characters


https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@200
PS1, Line 200: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */
line over 80 characters


https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@207
PS1, Line 207: 	PAD_CFG_GPI_SCI_LOW(GPIO_144, NONE, DEEP, LEVEL),/* GPIO_144 -- PEN_EJECT_ODL(wake) */
line over 80 characters


https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@208
PS1, Line 208: 	PAD_CFG_GPI_GPIO_DRIVER(GPIO_145, NONE, DEEP),/* GPIO_145 -- PEN_EJECT_ODL(notifications) */
line over 80 characters


https://review.coreboot.org/#/c/26874/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@209
PS1, Line 209: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_146, NONE, DEEP, NF5, HIZCRx0, DISPUPD),/* GPIO_146 -- NC */
line over 80 characters



-- 
To view, visit https://review.coreboot.org/26874
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e40dd90b2784596f055538e57ea67482c4c517a
Gerrit-Change-Number: 26874
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Jun 2018 00:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180606/490cc942/attachment.html>