[coreboot-gerrit] Change in coreboot[master]: cbfs: Fix compilation error with VBOOT enabled

Philipp Deppenwiese (Code Review) gerrit at coreboot.org
Tue Jun 5 15:26:30 CEST 2018


Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/26863 )

Change subject: cbfs: Fix compilation error with VBOOT enabled
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/26863/1/src/lib/cbfs.c
File src/lib/cbfs.c:

https://review.coreboot.org/#/c/26863/1/src/lib/cbfs.c@323
PS1, Line 323: #if IS_ENABLED(CONFIG_VBOOT) && !defined(__SMM__)
> I don't think this is the right answer. […]
woah ultra fast as always. :) Yeah but there is no vboot smm support AFAIK



-- 
To view, visit https://review.coreboot.org/26863
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10ae94d7936581bbb5ea49384122062bd4934ea5
Gerrit-Change-Number: 26863
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-CC: Aaron Durbin <adurbin at chromium.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 13:26:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/4b2ddb36/attachment.html>


More information about the coreboot-gerrit mailing list