[coreboot-gerrit] Change in coreboot[master]: payloads: Use NULL instead of 0 for pointer

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Jun 5 10:02:45 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26858 )

Change subject: payloads: Use NULL instead of 0 for pointer
......................................................................


Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/form/frm_driver.c
File payloads/libpayload/curses/form/frm_driver.c:

https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/form/frm_driver.c@4396
PS1, Line 4396:   FIELD_CELL *widevalue = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/form/frm_driver.c@4396
PS1, Line 4396:   FIELD_CELL *widevalue = NULL;
need consistent spacing around '*' (ctx:WxV)


https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/form/frm_driver.c@4507
PS1, Line 4507:   char *result = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/form/frm_driver.c@4575
PS1, Line 4575:   wchar_t *result = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/menu/m_global.c
File payloads/libpayload/curses/menu/m_global.c:

https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/menu/m_global.c@260
PS1, Line 260:       wchar_t *temp = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/menu/m_item_new.c
File payloads/libpayload/curses/menu/m_item_new.c:

https://review.coreboot.org/#/c/26858/1/payloads/libpayload/curses/menu/m_item_new.c@66
PS1, Line 66:   wchar_t *temp = NULL;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/26858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91d13586b92a106822df412fdc386d75968e3fb8
Gerrit-Change-Number: 26858
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 08:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/7a5c1a0b/attachment.html>


More information about the coreboot-gerrit mailing list