[coreboot-gerrit] Change in coreboot[master]: src: Use NULL enstead of 0 for pointer

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Jun 5 09:14:46 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26857 )

Change subject: src: Use NULL enstead of 0 for pointer
......................................................................


Patch Set 2:

(7 comments)

https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4.c
File util/cbfstool/lz4/lib/lz4.c:

https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4.c@799
PS2, Line 799:     *srcSizePtr = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c
File util/cbfstool/lz4/lib/lz4frame.c:

https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@937
PS2, Line 937:         *srcSizePtr = NULL;
code indent should use tabs where possible


https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@937
PS2, Line 937:         *srcSizePtr = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@1064
PS2, Line 1064:     *srcSizePtr = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26857/2/util/cbfstool/lz4/lib/lz4frame.c@1065
PS2, Line 1065:     *dstSizePtr = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26857/2/util/cbfstool/lzma/C/LzmaDec.c
File util/cbfstool/lzma/C/LzmaDec.c:

https://review.coreboot.org/#/c/26857/2/util/cbfstool/lzma/C/LzmaDec.c@838
PS2, Line 838:   *srcLen = *destLen = NULL;
please, no spaces at the start of a line


https://review.coreboot.org/#/c/26857/2/util/cbfstool/lzma/C/LzmaDec.c@971
PS2, Line 971:   *srcLen = *destLen = NULL;
please, no spaces at the start of a line



-- 
To view, visit https://review.coreboot.org/26857
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75fa4577055f25dde0a8b1044c005bba72cabd92
Gerrit-Change-Number: 26857
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 07:14:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/ab4dd37f/attachment.html>


More information about the coreboot-gerrit mailing list