[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Enable wake-over-wifi for octopus variants
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Tue Jun 5 02:46:16 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26854 )
Change subject: mb/google/octopus: Enable wake-over-wifi for octopus variants
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/26854/1/src/mainboard/google/octopus/variants/baseboard/gpio.c
File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/26854/1/src/mainboard/google/octopus/variants/baseboard/gpio.c@169
PS1, Line 169: PAD_CFG_GPI_SCI_LOW(GPIO_119, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE3_B */
line over 80 characters
https://review.coreboot.org/#/c/26854/1/src/mainboard/google/octopus/variants/bip/gpio.c
File src/mainboard/google/octopus/variants/bip/gpio.c:
https://review.coreboot.org/#/c/26854/1/src/mainboard/google/octopus/variants/bip/gpio.c@167
PS1, Line 167: PAD_CFG_GPI_SCI_LOW(GPIO_119, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE3_B */
line over 80 characters
--
To view, visit https://review.coreboot.org/26854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibae199c43e4d96da4c2f68f71a849c2f23d3e7b9
Gerrit-Change-Number: 26854
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 05 Jun 2018 00:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180605/2de937ad/attachment.html>
More information about the coreboot-gerrit
mailing list