[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/atlas: update HP IRQ pin's pad config
Sathyanarayana Nujella (Code Review)
gerrit at coreboot.org
Tue Jun 5 01:12:10 CEST 2018
Sathyanarayana Nujella has uploaded this change for review. ( https://review.coreboot.org/26851
Change subject: mb/google/poppy/variants/atlas: update HP IRQ pin's pad config
......................................................................
mb/google/poppy/variants/atlas: update HP IRQ pin's pad config
Issue observed on the board is: too many jack interrupts.
cat /proc/interrupts | grep da7219
58: 84292 15709 0 0 IO-APIC 58-fasteoi da7219-aad
Updated pad configuration for Jack IRQ pin to fix the issue.
BUG=b:109655907
TEST=Jack insertion & removal detection is working.
Change-Id: I41ef9d40325677b01ca94ec3215e7feded76dcc3
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
---
M src/mainboard/google/poppy/variants/atlas/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/26851/1
diff --git a/src/mainboard/google/poppy/variants/atlas/gpio.c b/src/mainboard/google/poppy/variants/atlas/gpio.c
index c1b3ccc..acaa225 100644
--- a/src/mainboard/google/poppy/variants/atlas/gpio.c
+++ b/src/mainboard/google/poppy/variants/atlas/gpio.c
@@ -279,7 +279,7 @@
/* F9 : I2C4_SCL ==> PCH_I2C4_AUDIO_1V8_SCL */
PAD_CFG_NF_1V8(GPP_F9, NONE, DEEP, NF1),
/* F10 : I2C5_SDA ==> HP_IRQ_GPIO */
- PAD_CFG_GPI_APIC(GPP_F10, NONE, PLTRST),
+ PAD_CFG_GPI_APIC(GPP_F10, 20K_PU, DEEP),
/* F11 : I2C5_SCL ==> SPKR_RST_L */
PAD_CFG_GPO(GPP_F11, 1, RSMRST),
/* F12 : EMMC_CMD */
--
To view, visit https://review.coreboot.org/26851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41ef9d40325677b01ca94ec3215e7feded76dcc3
Gerrit-Change-Number: 26851
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/bb48b2b2/attachment.html>
More information about the coreboot-gerrit
mailing list