[coreboot-gerrit] Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/22872 )

Change subject: security/crypto: Add crypto primitives for hashing data
......................................................................


Patch Set 26:

(5 comments)

https://review.coreboot.org/#/c/22872/21/src/security/Kconfig
File src/security/Kconfig:

https://review.coreboot.org/#/c/22872/21/src/security/Kconfig@17
PS21, Line 17: 
> replace all of these with: […]
Done


https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig
File src/security/crypto/Kconfig:

https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@15
PS21, Line 15: menu "Cryptographic Primitives"
             : 
             : config CRYPTO_HASH
> Do we need 2 levels of menus?
Done


https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@24
PS21, Line 24: ds on CRYPTO_HA
> Do these need to be user selectable, or would they be set from inside another Kconfig?
Done


https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@26
PS21, Line 26:   Enable this opti
> 1) Wouldn't 'depends on CRYPTO_HASH' be better? […]
Done


https://review.coreboot.org/#/c/22872/21/src/security/crypto/Kconfig@49
PS21, Line 49: 
> 1) How is listing what's supported useful? […]
Done



-- 
To view, visit https://review.coreboot.org/22872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1
Gerrit-Change-Number: 22872
Gerrit-PatchSet: 26
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1001824
Gerrit-Reviewer: Anonymous Coward #1001845
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 22:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/f299e065/attachment.html>