[coreboot-gerrit] Change in coreboot[master]: security/crypto: Add crypto primitives for hashing data

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22872 )

Change subject: security/crypto: Add crypto primitives for hashing data
......................................................................


Patch Set 24:

(12 comments)

https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash.h
File src/security/crypto/hash.h:

https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash.h@186
PS24, Line 186:  * 		if <alg> is invalid.
please, no space before tabs


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c
File src/security/crypto/hash/sha1.c:

https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@184
PS24, Line 184: 	while ((ctx->count % sizeof(ctx->buf)) != (sizeof(ctx->buf) - 8)) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@193
PS24, Line 193: 	for (i = 0; i < 5; i++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha1.c@277
PS24, Line 277: 	while ((ctx->count % sizeof(ctx->buf)) != (sizeof(ctx->buf) - 8)) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c
File src/security/crypto/hash/sha256.c:

https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@106
PS24, Line 106: 	for (i = 0; i < 8; i++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@142
PS24, Line 142: 		for (j = 0; j < 16; j++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@146
PS24, Line 146: 		for (j = 16; j < 64; j++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@150
PS24, Line 150: 		for (j = 0; j < 8; j++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha256.c@168
PS24, Line 168: 		for (j = 0; j < 8; j++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c
File src/security/crypto/hash/sha512.c:

https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@293
PS24, Line 293: 		for (j = 0; j < 16; j++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@297
PS24, Line 297: 		for (j = 16; j < 80; j++) {
braces {} are not necessary for single statement blocks


https://review.coreboot.org/#/c/22872/24/src/security/crypto/hash/sha512.c@301
PS24, Line 301: 		for (j = 0; j < 8; j++) {
braces {} are not necessary for single statement blocks



-- 
To view, visit https://review.coreboot.org/22872
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I807084ebfffdc159fe95c45b4e5f0820bbfee5e1
Gerrit-Change-Number: 22872
Gerrit-PatchSet: 24
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1001824
Gerrit-Reviewer: Anonymous Coward #1001845
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 21:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/ea8f283f/attachment.html>