[coreboot-gerrit] Change in coreboot[master]: security/vboot: Add interface for FSP 2.0 mrc caching

[Philipp Deppenwiese (Code Review)]

Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/24904 )

Change subject: security/vboot: Add interface for FSP 2.0 mrc caching
......................................................................


Patch Set 9:

(2 comments)

https://review.coreboot.org/#/c/24904/6/src/drivers/intel/fsp2_0/memory_init.c
File src/drivers/intel/fsp2_0/memory_init.c:

https://review.coreboot.org/#/c/24904/6/src/drivers/intel/fsp2_0/memory_init.c@149
PS6, Line 149: 	if (!mrc_cache_verify_hash(data, region_device_sz(&rdev)))
> if you guard that with 	if (IS_ENABLED(CONFIG_FSP2_0_USES_TPM_MRC_HASH)), you don't need to define w […]
We want have multiple implementations here


https://review.coreboot.org/#/c/24904/6/src/security/vboot/mrc_cache_hash_tpm.c
File src/security/vboot/mrc_cache_hash_tpm.c:

https://review.coreboot.org/#/c/24904/6/src/security/vboot/mrc_cache_hash_tpm.c@1
PS6, Line 1: /*
> You are breaking fsp2_0 memory_init.c here, as you are missing Makefile. […]
Done



-- 
To view, visit https://review.coreboot.org/24904
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41a458186c7981adaf3fea8974adec2ca8668f14
Gerrit-Change-Number: 24904
Gerrit-PatchSet: 9
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 20:44:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/e4e4b65d/attachment.html>