[coreboot-gerrit] Change in libgfxinit[master]: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI

Arthur Heymans (Code Review) gerrit at coreboot.org
Mon Jun 4 16:46:00 CEST 2018


Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26833 )

Change subject: g45/hw-gfx-gma-gmch-hdmi.adb: Use GMCH_HDMI_MODE_SELECT_DVI
......................................................................


Patch Set 2: Verified+1

> I wonder if PCH.HDMI doesn't know the bit or if it's just
 > implicitly
 > DVI (0).

It is implicitly DVI(0). The 2011 PCH datasheet has it at the same offset.


-- 
To view, visit https://review.coreboot.org/26833
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75c669b913ef4d5494d78bed55f8e38bba0b0362
Gerrit-Change-Number: 26833
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Comment-Date: Mon, 04 Jun 2018 14:46:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/ccb1f023/attachment.html>


More information about the coreboot-gerrit mailing list