[coreboot-gerrit] Change in coreboot[master]: soc/samsung: Get rid of device_t

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Jun 4 11:17:40 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26534 )

Change subject: soc/samsung: Get rid of device_t
......................................................................

soc/samsung: Get rid of device_t

Use of device_t has been abandoned in ramstage.

Change-Id: Ibf21100eb2232932ea52740bd5250319d3c9adfa
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/26534
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi at google.com>
---
M src/soc/samsung/exynos5250/cpu.c
M src/soc/samsung/exynos5420/cpu.c
2 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved



diff --git a/src/soc/samsung/exynos5250/cpu.c b/src/soc/samsung/exynos5250/cpu.c
index 9152343..2196144 100644
--- a/src/soc/samsung/exynos5250/cpu.c
+++ b/src/soc/samsung/exynos5250/cpu.c
@@ -56,7 +56,7 @@
  * involving lots of machine and callbacks, is hard to debug and
  * verify.
  */
-static void exynos_displayport_init(device_t dev, u32 lcdbase,
+static void exynos_displayport_init(struct device *dev, u32 lcdbase,
 		unsigned long fb_size)
 {
 	struct soc_samsung_exynos5250_config *conf = dev->chip_info;
@@ -107,7 +107,7 @@
 	lcd_ctrl_init(fb_size, &panel, (void *)lcdbase);
 }
 
-static void cpu_enable(device_t dev)
+static void cpu_enable(struct device *dev)
 {
 	unsigned long fb_size = FB_SIZE_KB * KiB;
 	u32 lcdbase = get_fb_base_kb() * KiB;
@@ -120,7 +120,7 @@
 	set_cpu_id();
 }
 
-static void cpu_init(device_t dev)
+static void cpu_init(struct device *dev)
 {
 	printk(BIOS_INFO, "CPU:   S5P%X @ %ldMHz\n",
 			cpu_id, get_arm_clk() / (1024*1024));
@@ -134,7 +134,7 @@
 	.scan_bus         = 0,
 };
 
-static void enable_exynos5250_dev(device_t dev)
+static void enable_exynos5250_dev(struct device *dev)
 {
 	dev->ops = &cpu_ops;
 }
diff --git a/src/soc/samsung/exynos5420/cpu.c b/src/soc/samsung/exynos5420/cpu.c
index f298018..cab23a6 100644
--- a/src/soc/samsung/exynos5420/cpu.c
+++ b/src/soc/samsung/exynos5420/cpu.c
@@ -69,7 +69,7 @@
  * involving lots of machine and callbacks, is hard to debug and
  * verify.
  */
-static void exynos_displayport_init(device_t dev, u32 lcdbase,
+static void exynos_displayport_init(struct device *dev, u32 lcdbase,
 		unsigned long fb_size)
 {
 	struct soc_samsung_exynos5420_config *conf = dev->chip_info;
@@ -129,7 +129,7 @@
 	}
 }
 
-static void cpu_enable(device_t dev)
+static void cpu_enable(struct device *dev)
 {
 	unsigned long fb_size = FB_SIZE_KB * KiB;
 	u32 lcdbase = get_fb_base_kb() * KiB;
@@ -150,7 +150,7 @@
 	set_cpu_id();
 }
 
-static void cpu_init(device_t dev)
+static void cpu_init(struct device *dev)
 {
 	printk(BIOS_INFO, "CPU:   S5P%X @ %ldMHz\n",
 			cpu_id, get_arm_clk() / 1000000);
@@ -164,7 +164,7 @@
 	.scan_bus         = 0,
 };
 
-static void enable_exynos5420_dev(device_t dev)
+static void enable_exynos5420_dev(struct device *dev)
 {
 	dev->ops = &cpu_ops;
 }

-- 
To view, visit https://review.coreboot.org/26534
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf21100eb2232932ea52740bd5250319d3c9adfa
Gerrit-Change-Number: 26534
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/df3a27d4/attachment.html>


More information about the coreboot-gerrit mailing list