[coreboot-gerrit] Change in coreboot[master]: src/sb/intel/common/spi.c: Adapt and link in romstage

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25414 )

Change subject: src/sb/intel/common/spi.c: Adapt and link in romstage
......................................................................


Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/25414/4/src/southbridge/intel/common/spi.c
File src/southbridge/intel/common/spi.c:

https://review.coreboot.org/#/c/25414/4/src/southbridge/intel/common/spi.c@324
PS4, Line 324: 		car_set_var(g_ichspi_lock, readw_(&ich7_spi->spis) & HSFS_FLOCKDN);
line over 80 characters


https://review.coreboot.org/#/c/25414/4/src/southbridge/intel/common/spi.c@964
PS4, Line 964: 	writel_ (0x1000, &cntlr->ich9_spi->fdoc);
space prohibited between function name and open parenthesis '('



-- 
To view, visit https://review.coreboot.org/25414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4671653c0b07ab5c4bf91128f18f142ce4f893cf
Gerrit-Change-Number: 25414
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Christoph Pomaska <cp_public at posteo.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 04 Jun 2018 08:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/25884a4e/attachment.html>