[coreboot-gerrit] Change in coreboot[master]: device: Only expose VGA_ROM_RUN on supported architectures

Patrick Georgi (Code Review) gerrit at coreboot.org
Mon Jun 4 10:24:37 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/26754 )

Change subject: device: Only expose VGA_ROM_RUN on supported architectures
......................................................................

device: Only expose VGA_ROM_RUN on supported architectures

The yabel emulator depends on IO ports, that aren't available on
ARM and MIPS. Add additional dependencies to fix compilation errors
with the default configuration.

Change-Id: If0e28b356c01cb3ae0739a54aa3531a2acedbfbb
Signed-off-by: Patrick Rudolph <patrick.rudolph at 9elements.com>
Reviewed-on: https://review.coreboot.org/26754
Reviewed-by: Nico Huber <nico.h at gmx.de>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/device/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved



diff --git a/src/device/Kconfig b/src/device/Kconfig
index a36b2e1..3d1d3fe 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -85,7 +85,7 @@
 # TODO: Explain differences (if any) for onboard cards.
 config VGA_ROM_RUN
 	bool "Run VGA Option ROMs"
-	depends on PCI && !MAINBOARD_FORCE_NATIVE_VGA_INIT
+	depends on PCI && (ARCH_X86 || ARCH_POWER8) && !MAINBOARD_FORCE_NATIVE_VGA_INIT
 	select HAVE_VGA_TEXT_FRAMEBUFFER
 	help
 	  Execute VGA Option ROMs in coreboot if found. This can be used

-- 
To view, visit https://review.coreboot.org/26754
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If0e28b356c01cb3ae0739a54aa3531a2acedbfbb
Gerrit-Change-Number: 26754
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180604/a730822b/attachment.html>


More information about the coreboot-gerrit mailing list